fix(release): sign release tags (git tag -s) - #70
Merged
Conversation
v1.2.0 was PGP-signed but v1.2.1 shipped unsigned because the recipe used `git tag -a` (annotated, unsigned). Switch to `-s` so `just release` produces signed tags using the maintainer's configured signing key. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
just releaseproduced an unsignedv1.2.1tag, whereasv1.2.0(and prior releases) were PGP-signed. Root cause: the recipe usedgit tag -a(annotated, unsigned). This switches it togit tag -sso every release tag is signed with the maintainer's configured signing key.release version: @echo "Creating release v{{version}}..." - git tag -a "v{{version}}" -m "Release v{{version}}" + git tag -s "v{{version}}" -m "Release v{{version}}" git push origin "v{{version}}"Evidence
git cat-file -p v1.2.0→ contains-----BEGIN PGP SIGNATURE-----git cat-file -p v1.2.1→ no signature block-suses the existing key — no new setup required.Note (separate decision)
The already-published
v1.2.1tag remains unsigned. Re-signing it would require force-updating the pushed tag (and would re-triggerrelease.yml). Left as-is unless you want me to re-sign/re-push it.🤖 Generated with Claude Code